Update update-record-factory.ts -> Fixes #30 and #28 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are not editing the images and multiple option is on, it should not try to update them
1ay1
changed the title
|
Please review this PR. I have to use this in another project and I have to change the code everything I deploy. |
dziraf
approved these changes
Jul 21, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Jul 21, 2021
## [2.0.1](v2.0.0...v2.0.1) (2021-07-21) ### Bug Fixes * only update files if files.length>0 (PR[#31](#31)) ([bb83813](bb83813))
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
to AfrazHussain/adminjs-upload
that referenced
this pull request
Feb 6, 2023
# 1.0.0 (2023-02-06) ### Bug Fixes * bump admin-versions ([466fdf8](466fdf8)) * bump AdminBro ([b9ec38e](b9ec38e)) * check for duplicate proprerties ([46c93ae](46c93ae)) * expires default to 24h when passing undefined ([41d0921](41d0921)) * fix expires prop in AWS provider ([19169aa](19169aa)) * fix mkdir bug for local-provider ([SoftwareBrothers#24](https://github.com/AfrazHussain/adminjs-upload/issues/24))([@sarcastic-verma](https://github.com/sarcastic-verma)) ([8dad188](8dad188)) * fixing wrong '/' for local adapter the right way ([2aeec1d](2aeec1d)) * gitignore settings for types ([43f6ad6](43f6ad6)) * javascript export ([df3b060](df3b060)) * missing size in file ([b2a3589](b2a3589)) * modified url for local storage provider ([acc34b8](acc34b8)) * not removing files after file change ([90bbb2b](90bbb2b)) * only update files if files.length>0 (PR[SoftwareBrothers#31](https://github.com/AfrazHussain/adminjs-upload/issues/31)) ([bb83813](bb83813)) * pass filesToUpload to drop zone ([a15237f](a15237f)) * payload hasn't been filtered from file ([1ae37cd](1ae37cd)) * remove aws from dependencies ([95b21e1](95b21e1)) * return updated record after multi upload ([a68bfa2](a68bfa2)) * types for validation ([90966f4](90966f4)) * url with extra / in S3 ([2182b60](2182b60)) * using properties.key as the property name ([26b33e5](26b33e5)) ### chore * rebrand AdminBro to AdminJS ([e020a56](e020a56)) * update AdminJS to v6 ([b82059c](b82059c)) ### Features * add bulk delete support ([d9b30d7](d9b30d7)) * add expiration time to links ([3f6ecfa](3f6ecfa)) * add google storage ([8344450](8344450)), closes [SoftwareBrothers#6](https://github.com/AfrazHussain/adminjs-upload/issues/6) * add local upload ([d643522](d643522)) * add multi file upload ([fcb425b](fcb425b)) * add option to change path of stored file ([29572e5](29572e5)) * add public acl to aws s3 ([6e9f10b](6e9f10b)) * Implement multiple file upload ([c303e21](c303e21)) * improve erro handing for multiple invocations ([391b639](391b639)) * pass context to adapter ([4a4a878](4a4a878)) * release ([62ab742](62ab742)) * release ([24f7b8c](24f7b8c)) ### BREAKING CHANGES * This package version should be used with AdminJS v6 * AdminBro has been rebranded to AdminJS. All package and repository names had been updated. 1. Update your dependencies to use new `adminjs` packages. - `admin-bro` -> `adminjs` for the core package - `@admin-bro/<package name>` -> `@adminjs/<package name>` for other modules 2. Update your custom CSS classes: - `.admin-bro_<component name>` -> `.adminjs_<component name>` (example: `.adminjs_Box`) 3. Search your project for `admin-bro` occurrences - most likely they will have to be updated to `adminjs`
github-actions bot
pushed a commit
to geekyayush/adminjs-upload
that referenced
this pull request
Jun 12, 2023
# 1.0.0 (2023-06-12) ### Bug Fixes * bump admin-versions ([466fdf8](466fdf8)) * bump AdminBro ([b9ec38e](b9ec38e)) * check for duplicate proprerties ([46c93ae](46c93ae)) * expires default to 24h when passing undefined ([41d0921](41d0921)) * fix expires prop in AWS provider ([19169aa](19169aa)) * fix mkdir bug for local-provider ([SoftwareBrothers#24](https://github.com/geekyayush/adminjs-upload/issues/24))([@sarcastic-verma](https://github.com/sarcastic-verma)) ([8dad188](8dad188)) * fixing wrong '/' for local adapter the right way ([2aeec1d](2aeec1d)) * gitignore settings for types ([43f6ad6](43f6ad6)) * javascript export ([df3b060](df3b060)) * missing size in file ([b2a3589](b2a3589)) * modified url for local storage provider ([acc34b8](acc34b8)) * not removing files after file change ([90bbb2b](90bbb2b)) * only update files if files.length>0 (PR[SoftwareBrothers#31](https://github.com/geekyayush/adminjs-upload/issues/31)) ([bb83813](bb83813)) * pass filesToUpload to drop zone ([a15237f](a15237f)) * payload hasn't been filtered from file ([1ae37cd](1ae37cd)) * remove aws from dependencies ([95b21e1](95b21e1)) * return updated record after multi upload ([a68bfa2](a68bfa2)) * types for validation ([90966f4](90966f4)) * url with extra / in S3 ([2182b60](2182b60)) ### chore * rebrand AdminBro to AdminJS ([e020a56](e020a56)) * update AdminJS to v6 ([b82059c](b82059c)) * v4 (SoftwareBrothers#65) ([2be1dab](2be1dab)), closes [SoftwareBrothers#65](https://github.com/geekyayush/adminjs-upload/issues/65) ### Features * add bulk delete support ([d9b30d7](d9b30d7)) * add expiration time to links ([3f6ecfa](3f6ecfa)) * add google storage ([8344450](8344450)), closes [SoftwareBrothers#6](https://github.com/geekyayush/adminjs-upload/issues/6) * add local upload ([d643522](d643522)) * add multi file upload ([fcb425b](fcb425b)) * add option to change path of stored file ([29572e5](29572e5)) * add public acl to aws s3 ([6e9f10b](6e9f10b)) * Implement multiple file upload ([c303e21](c303e21)) * improve erro handing for multiple invocations ([391b639](391b639)) * pass context to adapter ([4a4a878](4a4a878)) * release ([62ab742](62ab742)) * release ([24f7b8c](24f7b8c)) ### BREAKING CHANGES * The package won't support CJS anymore. * You now have to provide your ComponentLoader instance to the feature * This package version should be used with AdminJS v6 * AdminBro has been rebranded to AdminJS. All package and repository names had been updated. 1. Update your dependencies to use new `adminjs` packages. - `admin-bro` -> `adminjs` for the core package - `@admin-bro/<package name>` -> `@adminjs/<package name>` for other modules 2. Update your custom CSS classes: - `.admin-bro_<component name>` -> `.adminjs_<component name>` (example: `.adminjs_Box`) 3. Search your project for `admin-bro` occurrences - most likely they will have to be updated to `adminjs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are not editing the images and multiple option is on, it should not try to update them.
fixes #30 and #28