Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash multi exec on hard restart/crash #831

Open
keithchew opened this issue May 8, 2024 · 0 comments
Open

Flash multi exec on hard restart/crash #831

keithchew opened this issue May 8, 2024 · 0 comments

Comments

@keithchew
Copy link

keithchew commented May 8, 2024

Stress testing KeyDB on v6.3.4, we encountered a scenario where we got partial data written within a multi/exec block. Looking at a comment from Redis:

When using the append-only file, Redis makes sure to use a single write(2) syscall 
to write the transaction on disk. 

However if the Redis server crashes or is killed by the system administrator in some 
hard way it is possible that only a partial number of operations are registered. 

Redis will detect this condition at restart, and will exit with an error. 

Using the redis-check-aof tool it is possible to fix the append only file that will 
remove the partial transaction so that the server can start again.

What happens in KeyDB when Flash is used? I am guessing there is no equivalent check for partial written records after a crash. Just wanted to confirm, so that we are aware of it when the scenario happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant