Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default cookiecutter log directory path should be generic #4

Open
JoshKarpel opened this issue Feb 13, 2020 · 2 comments
Open

default cookiecutter log directory path should be generic #4

JoshKarpel opened this issue Feb 13, 2020 · 2 comments

Comments

@JoshKarpel
Copy link
Contributor

The cookiecutter template uses a log directory path that points to a directory on the author's computer:

"htcondor_log_dir": "/net/data_lhcb1b/user/jheuel/.condor_jobs"

I'm not sure what kind of interpolation is available where this value is used (https://github.com/Snakemake-Profiles/htcondor/blob/master/%7B%7Bcookiecutter.profile_name%7D%7D/grid-submit.py#L16), but perhaps the path could be relative to the directory the Snakefile is in? <snakefile_dir>/htcondor_logs, or similar? If not, perhaps relative to the user's home directory?

@JoshKarpel JoshKarpel changed the title cookiecutter log directory path should be generic default cookiecutter log directory path should be generic Feb 13, 2020
@jheuel
Copy link
Collaborator

jheuel commented Feb 14, 2020

Thanks for looking through the code! I agree that the path could be more generic, as it is just a placeholder that users need to adjust to their setup. However, in most cases it might be not the best idea to set this log file directory to somewhere in the users home directory, because the quota for home directories is usually quite small, while some form of extra storage for job outputs and logs is present (like here the /net stuff).

@JoshKarpel
Copy link
Contributor Author

Hmmm. Good point on the home directory - different clusters vary a lot in how they have that set up.

I wonder if instead of an absolute path, it could just be a plain relative path. Since the path is constructed by path joining in grid-submit.py, it would then be relative to where snakemake was run from (I assume; I'm not very familiar with snakemake yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants