Free gift stays in saved carts even when the promo rule with it is inactive

[alevashov]

Pre-conditions

Magento ver. 2.4.3-p1

We have a promo rule with free gift running from Feb 11 to Feb 15

During this period a visitor added number of products to the cart and became rightly eligible for a gift, so the gift appears in the cart

That is fine

The client hasn't finalized purchase that time.

Then he returned to the website Feb 23, when the rule with free gift wasn't active in the same browser.

Actual behaviour

Free gift was still in his cart, he finalized order and got this free gift

Expected behaviour

Free should not be gift not in the cart, because the rule that add it isn't active anymore

[PierreLeMaguer]

Hello,

thanks for using the module and sorry for the delay of the response.
Can you check in the cart and order in that case if they have the rule id in the column applied_rule_ids ?

Thanks,

[alek-s-andr]

Hi @PierreLeMaguer
I have checked all this orders (we have 4 such orders after Feb 15), in all of them the column applied_rule_ids do not has the rule_id which had free gift.

[PierreLeMaguer]

Thanks for the answer. I will investigate this and keep you in the loop.

[PierreLeMaguer]

This fix #68 was made for your kind of cases. I need to make more tests before merge it, but if you want you can try to install this patch and test it. I keep you informed when I merge it.

[alek-s-andr]

Thanks, we'll be waiting for merge because we have installed the module via composer.

[erfanimani]

@alek-s-andr you should still apply the patch and test it, look into Vaimo or cweagans composer patches.