Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

希望能转写BlockStorage至StorageCacheUtils #778

Closed
ClayCoffee opened this issue Aug 3, 2023 · 4 comments
Closed

希望能转写BlockStorage至StorageCacheUtils #778

ClayCoffee opened this issue Aug 3, 2023 · 4 comments

Comments

@ClayCoffee
Copy link

问题描述

汉化版更改导致对bs数据层的修改操作无法应用,如Galactifun的星门,等等
能不能像Slimefun保留旧版本物品适配一样保留BlockStorage适配(BlockStorage内的原方法转写至StorageCacheUtils)

问题复现率

必现

复现步骤

.

服务端类型

Spigot

Minecraft 版本

1.20.x

Slimefun 版本

Slimefun 2023.07.22

其他插件信息

No response

补充信息

No response

@ClayCoffee ClayCoffee added the 🐞 Bug 抓虫子 label Aug 3, 2023
@ClayCoffee ClayCoffee changed the title 希望能转写BlockStorage 希望能转写BlockStorage至StorageCacheUtils Aug 3, 2023
@StarWishsama
Copy link
Member

设计不太一样,不能直接适配🤔
有考虑过 ICompSlimefun

@Xzavier0722
Copy link
Collaborator

StorageCacheUtils中只有已加区块的方块数据,虽然可以适配大多数场景但是与BS原本定义差距还是有出入.. 而且一些接口做适配可能需要比较歪的办法,会引起很多意外的问题。之前删除一些接口其实也是为了让附属直接去适配而不是由本体兜底。
你具体是需要哪些接口?可以看看能不能做。

@ClayCoffee
Copy link
Author

Slimefun.getRegistry().getWorlds()
BlockStorage#getRawStorage()

返回的好像是一个世界的所有数据

@StarWishsama
Copy link
Member

Slimefun.getRegistry().getWorlds()
BlockStorage#getRawStorage()

返回的好像是一个世界的所有数据

新版会有 但是不是 BlockStorage 形式

@StarWishsama StarWishsama added 💬 讨论 and removed 🐞 Bug 抓虫子 labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants