Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing modifiers that add tank capacity to the tool can cause fluid overflow #5190

Open
Zen9890 opened this issue Mar 4, 2024 · 2 comments
Open

Removing modifiers that add tank capacity to the tool can cause fluid overflow #5190

Zen9890 opened this issue Mar 4, 2024 · 2 comments
Labels
1.18 Issue affects 1.18 1.19 Issue affects 1.19 Backport This issue is considered for backport to the previous supported version. Bug Issue describes unintended or broken behavior Resolved Issue is fixed in code, but there is not a release with that fix yet.

Comments

@Zen9890
Copy link

Zen9890 commented Mar 4, 2024

Minecraft Version

1.18.2

Forge Version

40.2.17

Mantle Version

1.9.50

Tinkers' Construct Version

3.7.1.155

Describe your issue

image
This happens when you have tool filled with fluid and then remove modifiers that add extra fluid capacity from the tool

Crash Report

No response

Other mods

Lots of them, didnt test with mods disabled this time

Tried reproducing with just Tinkers?

No

Performance Enchancers

Rubidium/Embeddium

Searched for known issues?

Searched open issues
@Zen9890 Zen9890 added 1.18 Issue affects 1.18 Bug Issue describes unintended or broken behavior Unreviewed Issue is new and is awaiting the team to review it labels Mar 4, 2024
@KnightMiner KnightMiner added 1.19 Issue affects 1.19 Resolved Issue is fixed in code, but there is not a release with that fix yet. and removed Unreviewed Issue is new and is awaiting the team to review it labels May 20, 2024
KnightMiner added a commit that referenced this issue May 20, 2024
@KnightMiner
Cleanup tool tanks taking advantage of tool stats and modifier traits
988d846 
Instead of shuffling the owner with every modifier implementing tanks, we have a single modifier that implements the tank, and other modifiers just add it as a trait
Modifiers using tanks can use the new helper to get and modify the fluid, instead of needing to talk to the module directly
Tank capacity has been moved from a volatile integer to a tool stat, reducing the need to have specialized modules for it. Custom tanks will just want to add their own custom stats or can handle capacity in another way if they prefer
Repackaged a few capability stuff as part of this commit
This refactor notably fixes fluid overflowing when tank capacity changes (#5190)
@KnightMiner
Copy link
Member

Fixed in 3.8.3.39 for 1.19.2. Will look into how feasible this is to fix in 1.18 as the fix took advantage of some API improvements.

@KnightMiner KnightMiner added the Backport This issue is considered for backport to the previous supported version. label May 20, 2024
@KnightMiner
Copy link
Member

This did not end up making it in the most recent 1.18.2 build. Will leave it open for now to reassess if we end up needing another build, but otherwise this will just never be fixed for that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.18 Issue affects 1.18 1.19 Issue affects 1.19 Backport This issue is considered for backport to the previous supported version. Bug Issue describes unintended or broken behavior Resolved Issue is fixed in code, but there is not a release with that fix yet.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KnightMiner @Zen9890