Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Looping on sending push notification may result in some push notification missing #47

Closed
royuen opened this issue Jun 3, 2016 · 1 comment
Closed

Looping on sending push notification may result in some push notification missing #47

royuen opened this issue Jun 3, 2016 · 1 comment
Assignees
@cheungpat
Milestone
0.13.1

Comments

@royuen
Copy link
Contributor

royuen commented Jun 3, 2016 •
edited
Loading

Case 1:
Put a for loop to send push notification in cloud code. Some push notification may be missed.

Case 2:
If a user has a lot of device tokens, some of them may be missed when we send push notification to that user
@royuen royuen added the Planned label Jun 7, 2016
@royuen royuen added this to the 0.12.2 milestone Jun 7, 2016
@royuen royuen modified the milestones: 0.12.2, 0.13, 0.14 Jun 29, 2016
@royuen royuen added Focus and removed Planned labels Jul 3, 2016
@cheungpat
Copy link
Contributor

I still think switching to the new HTTP/2 protocol/library is the way to go. At least you get response from APNS.

I think this might be relevant to the problem you are seeing
timehop/apns#70

@royuen royuen added in progress and removed Focus labels Jul 5, 2016
cheungpat added a commit to cheungpat/skygear-server that referenced this issue Jul 6, 2016
@cheungpat
Use HTTP/2 APNS protocol
88ad563 
This commit switch the underlying APNS library to
RobotsAndPencils/buford, which sends push notification to APNS
through HTTP/2 protocol. The new protocol provides immediate feedback
for each notification sent.

refs SkygearIO#47
@cheungpat cheungpat mentioned this issue Jul 6, 2016
Merged
rickmak added a commit that referenced this issue Jul 11, 2016
@rickmak
Use HTTP/2 APNS protocol
c97358b 
This commit switch the underlying APNS library to
RobotsAndPencils/buford, which sends push notification to APNS
through HTTP/2 protocol. The new protocol provides immediate feedback
for each notification sent.

refs #47
@royuen royuen modified the milestones: 0.13.1, 0.14 Jul 11, 2016
@rickmak rickmak closed this as completed Jul 12, 2016
@rickmak rickmak removed the In Review label Jul 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cheungpat cheungpat

Labels
None yet
Projects
None yet
Milestone
0.13.1
Development

No branches or pull requests
3 participants
@rickmak @cheungpat @royuen