Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dot in key create problem with FlatFile #83

Open
uiytt opened this issue Sep 7, 2023 · 1 comment
Open

Dot in key create problem with FlatFile #83

uiytt opened this issue Sep 7, 2023 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@uiytt
Copy link

uiytt commented Sep 7, 2023

Describe the bug
When there is a dot (.) in the key of a valid json (or any other) file like this :

{
	"test" : {
		"test2.test3": "Should work"
	}
} 

FlatFile#get("test.test2.test3") doesn't return anything.

But

{
	"test" : {
		"test2": {
			"test3" : "It works "
		}
	}
} 

Correctly return "It works"

Expected behavior
When the key of a file contains a dot, it should still work.

Desktop (please complete the following information):

  • SimplixStorage: 3.2.6
@KotlinFactory KotlinFactory self-assigned this Sep 22, 2023
@KotlinFactory KotlinFactory added bug Something isn't working enhancement New feature or request labels Sep 22, 2023
@yoyosource
Copy link
Collaborator

yoyosource commented Feb 29, 2024

I have one question regarding this issue. If you have this json object:

{
	"test" : {
		"test2.test3": "Should work",
	        "test2": {
		        "test3" : "It works "
	        }
	}
} 

What should this call FlatFile#get("test.test2.test3") return? It would not be deterministic, since both would match. I think a better idea would be that FlatFile#get("test.test2.test3") return the latter and FlatFile#get("test.test2\.test3") returns the former. This would make more sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants