Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethrow exceptions #79

Open
ChimpGamer opened this issue Mar 20, 2023 · 1 comment
Open

Rethrow exceptions #79

ChimpGamer opened this issue Mar 20, 2023 · 1 comment

Comments

@ChimpGamer
Copy link

Is your feature request related to a problem? Please describe.
At the moment we as users of this api cannot act on exceptions thrown within this api since they are already being caught.

Describe the solution you'd like
A clear and concise description of what you want to happen.
Rethrow the exception so we as users of the api can handle them they way we want to.

Describe alternatives you've considered
We'll a different api but without this issue there is no need to.

Additional context
Some examples of internal exception handling within the api
https://github.com/Simplix-Softworks/SimplixStorage/blob/master/src/main/java/de/leonhard/storage/internal/FlatFile.java#L126
https://github.com/Simplix-Softworks/SimplixStorage/blob/master/src/main/java/de/leonhard/storage/internal/FlatFile.java#L282
https://github.com/Simplix-Softworks/SimplixStorage/blob/master/src/main/java/de/leonhard/storage/internal/FlatFile.java#L298

@KotlinFactory
Copy link
Member

Hi thats a very valid critique.
Can you create a PR to change this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants