feat: take into account threshold for gradient calc #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When threshold is >1, gradient calculation doesn't take threshold into account. The "minimum" color of a gradient is often not the defined start of the gradient, depending on starboard config.
Fix works well in preliminary testing, but haven't extensively tested.
Also switches from
Math.floor
to bitwise flooring (~~
), due toMath.floor
not working properly with negatives