-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 [feat] : setting up routes for authentication #9
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
It is a problem only with OAuth or even with the plain old JWT-based auth as well? Also error logs with possible places the error might be occurring can be really useful. |
This is a problem that I am facing in the database section. It has nothing to do with the authentication part. You may make a API call to the sign in route (POST) with the apt request body to reproduce the error. |
The API request will look something similar to this curl --location 'http://localhost:3000/api/auth/signIn' \
--header 'Content-Type: application/json' \
--data-raw '{
"username": "[email protected]",
"password": "qwer1@"
}' |
@Shubham-Rasal I am yet to commit the reset password page. Not yet figured out how to fix the rendering issue. Right now, I am working on it. Beside that, other features seem to working as expected. Can you please confirm once ? I might have missed some edge cases? Or any vulnerability? |
@Shubham-Rasal I've come up with a workaround for the rendering problem, however I'm sure it's not the ideal solution. Let's see if @VaibhavNITK can offer any advice on how to handle it. The password reset page has been committed by me. @Shubham-Rasal @VaibhavNITK I would advise you everyone to test each of the parts and APIs in this PR and let me know what you think. Any and all comments would be much valued. @VaibhavNITK There is a TODO about creating a 403 error page in the reset page (under the auth folder). @Shubham-Rasal I think I've finished my part. If there are no modifications required, you can merge this PR right away. In a later PR, I would implement the OAuth based authentication. For now, let's just stay with the current JWT based authentication |
Fixes #7
Partially fixes #8
DONE :
TODO :
@Shubham-Rasal I am facing some issue in validating password in the sign in route. I need to have a look at the issue. I would suggest not to merge this PR right now.
@VaibhavNITK you may start styling these pages by pulling this branch in your machine.
@Shubham-Rasal @VaibhavNITK feel free to review this PR and post your thoughts in the comment section.