Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send whole data as output from version 2 APIs instead of filtering it #29

Open
kamal0808 opened this issue Nov 23, 2017 · 2 comments
Open
Assignees

Comments

@kamal0808
Copy link
Collaborator

Right now if I use feature/v2 to fetch all products, it gives out an array of products.
Instead, it should blurt out whatever comes out from the Vend APIs, i.e., array of products along with min and max version numbers of the data.

@pulkitsinghal
Copy link
Contributor

  1. The SDK was created to keep things simple, therefore it generally tends to hide metadata.
  2. It is fine if the purpose of the SDK evolves if the developers require more detailed knowledge to implement their usecases.

Go ahead and change it.

I don't think that additional properties would break the code for someone who has been using it to only view the array of products.

@kamal0808
Copy link
Collaborator Author

I don't think that additional properties would break the code for someone who has been using it to only view the array of products.
@pulkitsinghal It will break the code for them. Their arrays will be now contained in response.data instead of just response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants