Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Either combine or deprecate different implementations for fetching customers #27

Open
pulkitsinghal opened this issue Sep 22, 2017 · 0 comments

Comments

@pulkitsinghal
Copy link
Contributor

This example is one of many ways in which we can change our implementation to support all versions of the Vend API. It is not a solution which fits all situations, it just happened to be a simple usecase where altering path sufficed.

Anyway, we have two implementations: fetchCustomers and fetchCustomers2 and we should spend some time to either completely remove the 0.x endpoint or come up with an elegant way to support it both for the consumers of our SDK and in our implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant