Indicate zshenv is to be used when configuring ZSH version managers #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
reviewed
Jul 4, 2024
| @@ -8,18 +8,18 @@ with the same Ruby version as your projects, we need to properly set these envir | |||
| invoking your Ruby version manager. | |||
|
|
|||
| The extension runs a command using your shell's interactive mode, so that version managers configured in files such as | |||
| `~/.zshrc` are picked up automatically. The command then exports the environment information into JSON, so that we can | |||
| `~/.zshenv` are picked up automatically. The command then exports the environment information into JSON, so that we can | |||
There was a problem hiding this comment.
I'm not a zsh user. Does this file always exist? Or could there be users that don't have this file and only have ~/.zshrc?
I'm trying to understand if this is a recommendation that would work for everyone or if it might require extra steps.
There was a problem hiding this comment.
I think it's dependent of your ZSH setup. I run ZSH with Prezto. My ruby is sourced in ~/.zshrc with Mise and it works. So i'm not sure the doc change cover all cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2202
When configuring your ZSH based shell, we want to make sure the right file is indicated.
Implementation
Tested the tool via booting up the extension in VS Code.
Automated Tests
They're just readme changes, so modification of features.
Manual Tests
(I used rbenv for as my ruby version manager)
zshrc, and open VS Code. You'll see the extension fail to initializezshenv, and open VS Code. You'll see the extension initialize