Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: allows configs in sub-directories #4021

Open
zirkelc opened this issue Jun 10, 2024 · 1 comment
Open

[Feature]: allows configs in sub-directories #4021

zirkelc opened this issue Jun 10, 2024 · 1 comment
Labels
Type: Enhancement New feature or request

Comments

@zirkelc
Copy link

zirkelc commented Jun 10, 2024

What area(s) will this request affect?

App, Deployment

What type of change do you want to see?

New feature

Overview

Allow to specific the config by path for apps with multiple configs:

# uses shopify.app.test.toml
shopify app deploy --config test

# uses ./config/shopify.app.test.toml
shopify app deploy --config ./config/shopify.app.test.toml

Motivation

I have an app with multiple different configs for custom apps to test new features. Currently, all configs must be in the app directory and are identified by their config name in shopify.app.<config-name>.toml

/my-shopify-app
├── /app
│   ├── root.tsx
├── package.json
├── tsconfig.json
├── shopify.app.<config-name>.toml

I would like to move all configs into a sub-directory like /config or even /config/dev/

/my-shopify-app
├── /app
│   ├── root.tsx
├── /config
│   ├── shopify.app.<config-name>.toml
│   ├── /test
│   │   ├── shopify.app.<config-name>.toml
├── package.json
├── tsconfig.json
@zirkelc zirkelc added the Type: Enhancement New feature or request label Jun 10, 2024
@gonzaloriestra
Copy link
Contributor

Thanks for the suggestion! It makes sense to me and the implementation shouldn't be complex.

@nickwesselman what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants