-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request]: Remaining bulk actions #1120
Comments
Next one is kind of an edge case I think. I imported assets with kit and custodian resulting in 20 assets being part of a kit and having In custody status. However, all assets are In custody individually and not because the kit was assigned custody and assets inheriting the status. This can also happen without an import.
|
Yeah i know of this but tbh quite complex to solve. We ignore it for now. Also this is more related to imports. @rockingrohit9639 can you address the other points please? |
Okey so everything is resolved and released except this:
It is quite important we fix this. As far as I understand this happens because we only have the ids and when you are on page 2 we don't have the remaining data. What I would recommend is to update the data structure. We currently store an array of ids.
type Item = Asset | Kit | TeamMember | ....
type ItemsCollection = Record<Item['id'], Item> I am curious to hear your opinion. @rockingrohit9639 |
@jurrejansen @carlosvirreira this is all implemented and release. |
@DonKoko I was running through these to do quick tests. And I experienced an issue with bulk cancelling bookings. After loading for quite a while...
After checking out 1 of the bookings and trying again to bulk cancel it worked |
@jurrejansen was this in production or on staging? Do I understand correctly that you received the email for both bookings but only the status of 1 of them got changed? |
@DonKoko this was on app.shelf
|
@rockingrohit9639 I also found an issue: |
@rockingrohit9639 I have implemented a solution for that last point: #1170 |
Things to consider / add:
|
We should add bulk actions to the other models. Lets start 1 by one so we can progressively release them. We can make PR per model, but keep track of the whole scope here.
Kits
Category
Tags
Locations
Bookings
Custom fields
NRM
The text was updated successfully, but these errors were encountered: