Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Asset not found error gets captured 2 times for each instance #1103

Open
DonKoko opened this issue Jun 27, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working Priority: High Issues that are with very high priority

Comments

@DonKoko
Copy link
Contributor

DonKoko commented Jun 27, 2024

Contact Details

No response

What happened?

Steps to reproduce:

  1. Go to any 404 asset link. For example: http://localhost:3000/assets/ewqrewr/overview
  2. See errors in terminal
  3. See errors in Sentry

So in this flow we have the following routes:

  • assets.$assetId.tsx
  • assets.$assetId.overview.tsx

So when the user goes to a broken non-existing asset url, both those routes run. Each route tries to find the asset and fails and throws an error. Then we see 2 different errors in Sentry and in the terminal, even tho they are related to the same instance.

What is the expected behaviour?

Throw the error just 1 time.

I am wondering if switching to single fetch will resolve this. IMO it should.

@DonKoko DonKoko added the bug Something isn't working label Jun 27, 2024
@DonKoko DonKoko self-assigned this Jun 27, 2024
@DonKoko DonKoko added the Priority: High Issues that are with very high priority label Jun 27, 2024
@DonKoko
Copy link
Contributor Author

DonKoko commented Jun 27, 2024

hey @rphlmr. Do you have any idea how we can handle this, before we switch to single fetch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority: High Issues that are with very high priority
Projects
None yet
Development

No branches or pull requests

1 participant