-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request]: Asset index - store searchParams #1065
Comments
hey @rphlmr. I know you used that a lot so I wanted to hear your opinion. Could we maybe use the |
Hey 👋 What about a cookie (not necessary a session cookie, a basic one)? |
@rphlmr yeah I think we might have to go the cookie way. I like the idea of scoping it based on the path of the assets index so we don't send it with each request but only for that url. @rajeshj11 is this an issue you might want to work on? |
yeah, i would like to give it a try. |
@DonKoko please assign it to me. I will also check other approaches and will let you know about them before start the development |
Thanks @rajeshj11 . I think the cookie approach is still the best as we can handle it on the server this way. Let me know and lets get started on this. |
@jurrejansen @carlosvirreira this is deployed to staging and ready to be tested. Needs to be tested carefully as it might break some filters.
PLS let me know if all is good and we can release it. |
@DonKoko seems to work smoothly, tested all filters (present on asset index). I did notice if you switch through different accounts (logging out / in) that have access to the same workspace the filter config gets stored as well. This is expected I guess cause it works with cookies, not a bad thing and not really a realistic case. Anyways, didn't come across any issues |
Happy to release @DonKoko |
Contact Details
No response
Is your feature request related to a problem? Please describe?
When I have some filters active on the asset asset and then I navigate to a different page, I want those filters to persist when I come back to the asset index.
Describe the solution you'd like
Store the searchParams in a localStorage, the question is how do we make this smooth. The reason I ask is because localStorage is only accessible on the client, so it will be a very ugly flickr if we trigger the loader and once we get localStorage params it will reload basically.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: