Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation failures on Linux for Rust 1.72.0 - 1.80.0 #202

Open
amzn-narubin opened this issue Aug 7, 2024 · 2 comments
Open

Compilation failures on Linux for Rust 1.72.0 - 1.80.0 #202

amzn-narubin opened this issue Aug 7, 2024 · 2 comments

Comments

@amzn-narubin
Copy link

Which versions of the rust toolchain does Hoard support? Is there an MSRV? Getting various compilation errors.

Rust 1.80.0:

❯ cargo build --release
# <bunch of build output...>
55.88   --> /home/narubin/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.29/src/format_description/parse/mod.rs:83:9
55.89    |
55.89 83 |     let items = format_items
55.89    |         ^^^^^
55.89 ...
55.89 86 |     Ok(items.into())
55.89    |              ---- type must be known at this point
55.89    |
55.89 help: consider giving `items` an explicit type, where the placeholders `_` are specified
55.89    |
55.89 83 |     let items: Box<_> = format_items
55.89    |              ++++++++
55.89
56.52 For more information about this error, try `rustc --explain E0282`.
56.54 error: could not compile `time` (lib) due to 1 previous error

This seems to be related to rust-lang/rust#124736 but not sure.

Rust 1.72.0 - 1.79.0:

warning: lint `unaligned_references` has been removed: converted into hard error, see issue #82523 <https://github.com/rust-lang/rust/issues/82523> for more information
  --> src/lib.rs:50:1
   |
50 | unaligned_references,
   | ^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(renamed_and_removed_lints)]` on by default

error: unnecessary qualification
   --> src/checkers/history/operation/mod.rs:160:29
    |
160 |             <OperationV2 as serde::Deserialize>::deserialize(
    |                             ^^^^^^^^^^^^^^^^^^
    |
note: the lint level is defined here
   --> src/lib.rs:61:1
    |
61  | unused_qualifications,
    | ^^^^^^^^^^^^^^^^^^^^^

error: unnecessary qualification
   --> src/checkers/history/operation/mod.rs:172:29
    |
172 |             <OperationV1 as serde::Deserialize>::deserialize(
    |                             ^^^^^^^^^^^^^^^^^^

warning: `hoard` (lib) generated 1 warning
error: could not compile `hoard` (lib) due to 2 previous errors; 1 warning emitted

OS:

❯ cat /etc/os-release
NAME="Ubuntu"
VERSION="20.04.6 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.6 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal
@Shadow53
Copy link
Owner

Thanks for the report! MSRV on main is currently 1.70.0, as I have not updated anything in a while. #203 will update dependencies to latest, remove lints that no longer exist, and generally clean things up, though.

@Shadow53
Copy link
Owner

This should be fixed with 0.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants