Skip to content
This repository has been archived by the owner on Jun 17, 2020. It is now read-only.

'Share birth record' Percy screenshot has random data #162

Open
mermop opened this issue Aug 28, 2019 · 2 comments · Fixed by #164
Open

'Share birth record' Percy screenshot has random data #162

mermop opened this issue Aug 28, 2019 · 2 comments · Fixed by #164
Labels
bug Something isn't working

Comments

@mermop
Copy link
Member

mermop commented Aug 28, 2019

Anything with random data creates false Percy diffs and slows down merging

Screen Shot 2019-08-29 at 10 38 37 AM
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.94. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the bug Something isn't working label Aug 28, 2019
@mermop mermop mentioned this issue Aug 28, 2019
Merged
@mermop
Copy link
Member Author

mermop commented Aug 30, 2019

This still seems to be occurring despite #164

@mermop mermop reopened this Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 Use deterministic Faker seed ServiceInnovationLab/feijoa
1 participant
@mermop