-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added quitting examples for all lanaguges/translations #1882
added quitting examples for all lanaguges/translations #1882
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
{{< badge-code >}} | ||
{{< /tab >}} | ||
{{% tab header="Python" %}} | ||
{{< gh-codeblock path="examples/python/tests/drivers/test_options.py#L13" >}} | ||
{{% /tab %}} | ||
{{< tab header="CSharp" >}} | ||
{< gh-codeblock path="examples/java/src/test/java/dev/selenium/getting_started/FirstScript.java#L29" >} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @shbenzer ,
thank you for the PR.
the code is pointing to java
file, it should point to c# code
{{< badge-code >}} | ||
{{< /tab >}} | ||
{{% tab header="Python" %}} | ||
{{< gh-codeblock path="examples/python/tests/drivers/test_options.py#L13" >}} | ||
{{% /tab %}} | ||
{{< tab header="CSharp" >}} | ||
{< gh-codeblock path="examples/java/src/test/java/dev/selenium/getting_started/FirstScript.java#L29" >} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above...!
User description
Added code examples for driver.quit in all languages and translations
Description
Added code examples for driver.quit in all languages and translations
Motivation and Context
documentation should be as comprehensive as possible
Types of changes
Checklist
PR Type
Documentation
Description
driver.quit
code examples in multiple languages including Java, CSharp, JavaScript, and Kotlin.Changes walkthrough 📝
_index.en.md
Add `driver.quit` code examples in multiple languages
website_and_docs/content/documentation/webdriver/drivers/_index.en.md
driver.quit
in Java, CSharp, JavaScript,and Kotlin.
_index.ja.md
Add `driver.quit` code examples in Japanese documentation
website_and_docs/content/documentation/webdriver/drivers/_index.ja.md
driver.quit
in Java, CSharp, JavaScript,and Kotlin.
_index.pt-br.md
Add `driver.quit` code examples in Portuguese documentation
website_and_docs/content/documentation/webdriver/drivers/_index.pt-br.md
driver.quit
in Java, CSharp, JavaScript,and Kotlin.
_index.zh-cn.md
Add `driver.quit` code examples in Chinese documentation
website_and_docs/content/documentation/webdriver/drivers/_index.zh-cn.md
driver.quit
in Java, CSharp, JavaScript,and Kotlin.