Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1539 #1871

Closed
wants to merge 7 commits into from
Closed

Feature 1539 #1871

wants to merge 7 commits into from

Conversation

shbenzer
Copy link
Contributor

@shbenzer shbenzer commented Aug 19, 2024

User description

commit for feature #1539

Description

added example differentiating between .// and // when utilizing xpath
added to all translations

Motivation and Context

increase documentation coverage

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

documentation, enhancement


Description

  • Added setup and teardown functions in Python Selenium tests to improve test organization.
  • Introduced examples for using Selenium Manager, demonstrating setup with and without it.
  • Enhanced documentation by adding sections on implementing Selenium Manager in scripts across multiple languages.
  • Provided examples and explanations for using XPATH in element finders, highlighting the importance of using "." for current elements.
  • Updated Selenium getting started guides to include setup and teardown instructions for Python.

Changes walkthrough 📝

Relevant files
Enhancement
2 files
using_selenium_tests.py
Add setup and teardown functions for Selenium tests           

examples/python/tests/getting_started/using_selenium_tests.py

  • Added setup and teardown functions for Selenium tests.
  • Improved test organization with setup and teardown.
  • +8/-0     
    usage.py
    Add examples for Selenium Manager usage                                   

    examples/python/tests/selenium_manager/usage.py

  • Added examples for using Selenium Manager.
  • Demonstrated setup with and without Selenium Manager.
  • +12/-0   
    Documentation
    9 files
    selenium_manager.en.md
    Document Selenium Manager implementation in scripts           

    website_and_docs/content/documentation/selenium_manager.en.md

  • Added section on implementing Selenium Manager in scripts.
  • Included Python code examples for Selenium Manager.
  • +23/-0   
    selenium_manager.ja.md
    Document Selenium Manager implementation in scripts           

    website_and_docs/content/documentation/selenium_manager.ja.md

  • Added section on implementing Selenium Manager in scripts.
  • Included Python code examples for Selenium Manager.
  • +23/-0   
    selenium_manager.pt-br.md
    Document Selenium Manager implementation in scripts           

    website_and_docs/content/documentation/selenium_manager.pt-br.md

  • Added section on implementing Selenium Manager in scripts.
  • Included Python code examples for Selenium Manager.
  • +23/-0   
    selenium_manager.zh-cn.md
    Document Selenium Manager implementation in scripts           

    website_and_docs/content/documentation/selenium_manager.zh-cn.md

  • Added section on implementing Selenium Manager in scripts.
  • Included Python code examples for Selenium Manager.
  • +23/-0   
    finders.en.md
    Add XPATH usage examples in element finders                           

    website_and_docs/content/documentation/webdriver/elements/finders.en.md

  • Added examples for using XPATH from current element.
  • Explained the use of "." in XPATH for current elements.
  • +12/-0   
    finders.ja.md
    Add XPATH usage examples in element finders                           

    website_and_docs/content/documentation/webdriver/elements/finders.ja.md

  • Added examples for using XPATH from current element.
  • Explained the use of "." in XPATH for current elements.
  • +11/-0   
    finders.zh-cn.md
    Add XPATH usage examples in element finders                           

    website_and_docs/content/documentation/webdriver/elements/finders.zh-cn.md

  • Added examples for using XPATH from current element.
  • Explained the use of "." in XPATH for current elements.
  • +11/-0   
    using_selenium.en.md
    Document setup and teardown in Selenium guide                       

    website_and_docs/content/documentation/webdriver/getting_started/using_selenium.en.md

  • Added setup and teardown sections for Python.
  • Linked to Python code examples for setup and teardown.
  • +9/-0     
    using_selenium.ja.md
    Document setup and teardown in Selenium guide                       

    website_and_docs/content/documentation/webdriver/getting_started/using_selenium.ja.md

  • Added setup and teardown sections for Python.
  • Linked to Python code examples for setup and teardown.
  • +9/-0     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    netlify bot commented Aug 19, 2024

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 18ae80e

    @codiumai-pr-agent-pro codiumai-pr-agent-pro bot added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 19, 2024
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    Hardcoded Path
    The setup_without_selenium_manager function uses a hardcoded path for the Chrome executable, which may not be portable across different systems.

    Inconsistent Indentation
    The added code blocks have inconsistent indentation, which may affect readability and potentially cause issues in Python code examples.

    @diemol
    Copy link
    Member

    diemol commented Aug 19, 2024

    Feature 1539 does not mention Selenium Manager, but this PR does. Can you please clarify? I merged a moment ago some changes related to Selenium Manager.

    @shbenzer
    Copy link
    Contributor Author

    @diemol I realized with this push that my other changes were being integrated into my PR, so I included them in the description to make review easier

    @shbenzer shbenzer closed this Aug 19, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    documentation Improvements or additions to documentation enhancement New feature or request Review effort [1-5]: 2
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants