Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announcement fetch issue... #681

Open
jferas opened this issue May 29, 2024 · 0 comments
Open

Announcement fetch issue... #681

jferas opened this issue May 29, 2024 · 0 comments

Comments

@jferas
Copy link
Contributor

jferas commented May 29, 2024

An interesting error has surfaced now that we use env vars for the subgraph URLs.. related to "falling back" to querying logs for announcements.

When UmbraJs queries for announcements, it first tries the subgraph URL configured via env var to fetch the announcements via GraphQL. If that fails, for whatever reason, it falls back to querying the node logs. However, for mainnet, the node returns with this error, which UmbraJs is not handling well: "RPC Error: query returned more than 10000 results"

At first I thought this was related to the recent changes I made related putting the StealthKeyChanged events into the subgraph.. but I went back to the master branch and I see this error there as well.

This happening because I am now able to break the subgraph query by providing an invalid URL for the env var in my development environment.. previously, the subgraph URLS were hard-coded in UmbraJs source code.. so the likelihood of the subgraph query failing was pretty low.

No sure if I like any of the possible solutions for this (breaking the query up into chunks when the error is detected.. or providing an alternate subgraph URL to try) they all feel kind of expensive.. but I caused this problem via purposeful mis-configuration on my part, this same error could occur in prod even if we are properly configured and we have some kind if issue preventing us from accessing the sub-graph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant