-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce default number of benchmark rounds #6234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, easy change, LGTM!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6234 +/- ##
=======================================
Coverage 89.83% 89.83%
=======================================
Files 88 88
Lines 23315 23315
Branches 4338 4338
=======================================
Hits 20945 20945
Misses 1644 1644
Partials 726 726 ☔ View full report in Codecov by Sentry. |
⏱️ Performance Benchmark Report: d8689daPerformance shifts
Full benchmark results
Generated by GHA run |
Any chance of this being merged soon? |
🚀 Pull Request
Description
Recent experience has shown that benchmarks run on GitHub actions are very accurate. I originally set the default of 4 rounds to compensate for an assumed inaccuracy of GHA (given it's a shared resource). I would like to try with 3, and if that's still accurate I might consider dropping to 2.
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: