Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Matplotlib min version in pyproject.toml #2276

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented Oct 16, 2023

Rationale

I missed this one at #2258.

Does the fact that this pin is specified in the main dependencies here mean that it is impossible to install Cartopy in an environment with an older Matplotlib and therefore this check is redundant?

assert _MPL_35, 'Cartopy is only supported with Matplotlib 3.5 or greater.'

I have a vague memory that Matplotlib was once an optional dependency, which could be why it was written to error on import.

Implications

@greglucas
Copy link
Contributor

Does the fact that this pin is specified in the main dependencies here mean that it is impossible to install Cartopy in an environment with an older Matplotlib and therefore this check is redundant?

Yes that should be the case, so I think you can remove that line.

I have a vague memory that Matplotlib was once an optional dependency, which could be why it was written to error on import.

You are correct. We updated it here: #1876 which I still think makes sense because a user should probably use pyproj/shapely directly if they don't want the interaction with MPL.

@greglucas greglucas merged commit 4f2f187 into SciTools:main Oct 20, 2023
11 checks passed
@rcomer rcomer deleted the mpl-pyproject branch October 20, 2023 13:10
@QuLogic QuLogic added this to the Next Release milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants