Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Change Stamen image tiles over to Google #2265

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

greglucas
Copy link
Contributor

This changes examples that used Stamen over to Google. The Stamen versions are no longer accessible without an API key, so switching over to a public tile server is the easiest fix for now.

@greglucas greglucas added this to the Next Release milestone Oct 8, 2023
Copy link
Member

@rcomer rcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 72 of the ellipse example also mentions Stamen in the comment.

examples/scalar_data/eyja_volcano.py Outdated Show resolved Hide resolved
@greglucas greglucas force-pushed the rm-stamen-docs branch 2 times, most recently from dc2e37b to 224527a Compare October 9, 2023 16:00
@rcomer
Copy link
Member

rcomer commented Oct 12, 2023

Cycling to re-run tests...

@rcomer rcomer closed this Oct 12, 2023
@rcomer rcomer reopened this Oct 12, 2023
@rcomer
Copy link
Member

rcomer commented Oct 12, 2023

Circle did not re-start 😕

@rcomer
Copy link
Member

rcomer commented Oct 12, 2023

OK Circle now re-ran but it looks like it didn't pick up the changes from #2264. @greglucas do you fancy rebasing?

This changes examples that used Stamen over to Google. The Stamen
versions are no longer accessible without an API key, so switching
over to a public tile server is the easiest fix for now.
@greglucas
Copy link
Contributor Author

OK Circle now re-ran but it looks like it didn't pick up the changes from #2264. @greglucas do you fancy rebasing?

Done, and all looks good now.

Circle did not re-start 😕

I think you might be able to log into CircleCI and manually click the re-run button on the job, but I think I also remember something about CircleCI not referencing the latest HEAD of upstream in that case, so the other updates that were merged wouldn't be brought along, but I am not certain of that.

@rcomer
Copy link
Member

rcomer commented Oct 12, 2023

I think you might be able to log into CircleCI and manually click the re-run button on the job, but I think I also remember something about CircleCI not referencing the latest HEAD of upstream in that case, so the other updates that were merged wouldn't be brought along, but I am not certain of that.

Yep, that's what I did after the close-reopen didn't restart it, but then discovered what you say about it not getting the updates from upstream.

Great to have a full set of green ticks!

@rcomer rcomer merged commit f946084 into SciTools:main Oct 12, 2023
11 checks passed
@greglucas greglucas deleted the rm-stamen-docs branch October 12, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants