-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Change Stamen image tiles over to Google #2265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 72 of the ellipse example also mentions Stamen in the comment.
dc2e37b
to
224527a
Compare
Cycling to re-run tests... |
Circle did not re-start 😕 |
OK Circle now re-ran but it looks like it didn't pick up the changes from #2264. @greglucas do you fancy rebasing? |
This changes examples that used Stamen over to Google. The Stamen versions are no longer accessible without an API key, so switching over to a public tile server is the easiest fix for now.
224527a
to
fd66d62
Compare
Done, and all looks good now.
I think you might be able to log into CircleCI and manually click the re-run button on the job, but I think I also remember something about CircleCI not referencing the latest HEAD of upstream in that case, so the other updates that were merged wouldn't be brought along, but I am not certain of that. |
Yep, that's what I did after the close-reopen didn't restart it, but then discovered what you say about it not getting the updates from upstream. Great to have a full set of green ticks! |
This changes examples that used Stamen over to Google. The Stamen versions are no longer accessible without an API key, so switching over to a public tile server is the easiest fix for now.