Bump minimum Matplotlib version to 3.5 #2258
Conversation
| @@ -497,7 +498,10 @@ def test_gridliner_title_adjust(): | |||
| plt.rcParams['axes.titley'] = None | |||
|
|
|||
| fig = plt.figure(layout='constrained') | |||
| fig.get_layout_engine().set(h_pad=1/8) | |||
| if _MPL_36: | |||
| fig.get_layout_engine().set(h_pad=1/8) | |||
There was a problem hiding this comment.
The deprecation note on set_constrained_layout_pads suggests that the above should work from v3.6, but I have not actually tested.
https://matplotlib.org/stable/api/figure_api.html#matplotlib.figure.Figure.set_constrained_layout_pads
|
|
||
|
|
||
| @pytest.mark.natural_earth | ||
| @pytest.mark.mpl_image_compare( | ||
| filename="igh_land.png", tolerance=0.5 if _MPL_35 else 3.6) | ||
| filename="igh_land.png", tolerance=0.5 if _MPL_36 else 3.6) |
There was a problem hiding this comment.
CI fails here if the tolerance is set to 0.5 with mpl 3.5.
There was a problem hiding this comment.
I am confused by this because it looks like the tolerances were set at #2058, when mpl 3.5.2 would have been the newest version 😕
There was a problem hiding this comment.
I wouldn't read too much into that. Maybe the image was made with a main checkout at the time or something? Our tests are often brittle to these things, so this seems fine to me to bump one version chalking it up to we didn't know exactly which minimum version was needed.
Maybe we should think about testing with all versions of Matplotlib that we support though rather than only the newest and oldest.
Rationale
As agreed in #2252. Hopefully the minimum version tests are now no more broken than the others.
Implications