-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use boundary to compute axes domain in gridliner #1538
base: main
Are you sure you want to change the base?
Conversation
I think this approach cannot be used alone, since it will never work for polar plot for example. |
Now it works well with the best of the two algo. |
Could you add the image as a test? |
This may need a rebase to fix CI. |
It looks like you've brought some duplicate commits into this. Can you try to rebase onto master instead of merging master into this branch? I'm not sure why Appveyor failed on the gridliner image tests, but Travis didn't. Maybe it will fix itself with a rerun of the CI... |
@greglucas how to proceed with this rebasing? |
I think you have to delete the commits through an interactive rebase, or at least that's how I've done it when things get out of sync between branches.
That should give you a list of all the commits to choose from and then just keep the ones you want and delete the others. Probably just keeping all of your commits and removing all the merges/other people's commits from the list. |
Fix SciTools#1443 Merge the old and the new algo for the axes domain estimate The coordinates of the outline are simply added to the rasterised coordinates. In addition, the rasterized coordinates are generated with a non-even number of ticks to make sure to catch the center when bounds are symetric. Add gridliner_orthographic test This tests Gridliner._axes_domain Update figs due to new gridliner axes domain Fix figure testing for crs Fix tolerance for test_gridliner Remove unneeded call to ravel
5f5570d
to
da219bc
Compare
|
Rationale
Gridliner._axes_domain
discretizes the unitary domain to find min/max of longitudes and latitudes.This discretization makes approximative the estimate if bounds.
This PR directly uses native projection boundary to find min and max.
The PR is quite simple and I may have missed some subtleties.
I didn't updated the figures since alot of them are modified and I'm waiting for feedback.
Implications
Gridlines are properly plotted until the boundary.
Fixes #1443