Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Natural Earth: Include version in URL #2293

Open
kaedonkers opened this issue Nov 29, 2023 · 0 comments · May be fixed by #2351
Open

Natural Earth: Include version in URL #2293

kaedonkers opened this issue Nov 29, 2023 · 0 comments · May be fixed by #2351

Comments

@kaedonkers
Copy link
Member

Description

There are now five versions of Natural Earth features but currently the URL to download them in cartopy does not specify a version:
https://github.com/SciTools/cartopy/blob/main/lib/cartopy/io/shapereader.py#L323

The AWS S3 bucket that now hosts Natural Earth features supports version numbers:
nvkelso/natural-earth-vector#246 (comment)
but this has not been implemented in cartopy, which instead pulls the latest version available.

While this is not an issue in itself, adjusting the URL to optionally include the version of the Natural Earth feature will result in more reproducible behaviour.

@lgolston lgolston linked a pull request Mar 15, 2024 that will close this issue
@rcomer rcomer linked a pull request Mar 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant