Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type check and conversion in initializers #212

Open
MartinuzziFrancesco opened this issue Mar 8, 2024 · 2 comments · May be fixed by #213
Open

Add type check and conversion in initializers #212

MartinuzziFrancesco opened this issue Mar 8, 2024 · 2 comments · May be fixed by #213

Comments

@MartinuzziFrancesco
Copy link
Member

Following issue 21 in WeightInitializers.jl we should do something similar for the initializers that we have here
@avik-pal
Copy link
Member

avik-pal commented Mar 9, 2024

For centralized maintenance, I think it makes sense to move those initializers to WeightInitializers as well?

@MartinuzziFrancesco
Copy link
Member Author

that's a good point, I'll finish dealing with issue 21 and then we can move them there

@MartinuzziFrancesco MartinuzziFrancesco linked a pull request Mar 12, 2024 that will close this issue
Move initializers to WeightInitializers.jl #213
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move initializers to WeightInitializers.jl SciML/ReservoirComputing.jl
2 participants
@MartinuzziFrancesco @avik-pal