New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-write der_T equation #57

Closed

ValentinKaisermayer opened this issue May 21, 2022 · 1 comment

Contributor

ValentinKaisermayer commented May 21, 2022

ModelingToolkitStandardLibrary.jl/src/Thermal/HeatTransfer/ideal_components.jl

Lines 23 to 27 in 5ff99e5

    
           eqs = [ 
        
               T ~ port.T 
        
               der_T ~ D(T) 
        
               D(T) ~ port.Q_flow / C 
        
           ]

@YingboMa would this still result in an implicit DAE or resolve the issue? From a users point of view it should be the same.

eqs = [ 
     T ~ port.T 
     der_T ~ port.Q_flow / C
     D(T) ~  der_T 
 ]

Contributor Author

ValentinKaisermayer commented May 21, 2022

der_T is part of the original Modelica component but I think is only meant to be an alias.

ValentinKaisermayer mentioned this issue

Make thermal models ODEs again #73

Merged

ChrisRackauckas closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment