Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialization issue in CI #328

Closed
baggepinnen opened this issue Sep 12, 2024 · 3 comments · Fixed by #329
Closed

Initialization issue in CI #328

baggepinnen opened this issue Sep 12, 2024 · 3 comments · Fixed by #329
Assignees
Labels
bug Something isn't working

Comments

@baggepinnen
Copy link
Contributor

CI has never been made to pass for this repo on MTKv9, an error

Initialization expression model₊inertia₊phi(t) is currently not supported. If its a higher order derivative expression, then only the dummy derivative expressions are supported.

appears. Introduced in #271

https://github.com/SciML/ModelingToolkitStandardLibrary.jl/actions/runs/10812682331/job/29994875171#step:6:193

@ChrisRackauckas
Copy link
Member

CI has never been made to pass for this repo on MTKv9, an error

Here's a merge of the doc build working on July 29th:

https://github.com/SciML/ModelingToolkitStandardLibrary.jl/actions/runs/10143438690/job/28044805481#step:5:329

Saying that doc builds are failing because of a failure in February (#271) and "CI has never been made to pass for this repo on MTKv9" is very easy to verify that it's not true... so let's get back to reality.

Looks like it was introduced in #313 70f767c

The doc build did pass, but it seems to be because the initialization hit the ODE case so the typo on the given initial values was ignored. SciML/ModelingToolkit.jl#3032 exposes that typo in the tutorial, so #329 looks to be a fix.

@baggepinnen
Copy link
Contributor Author

Ok, the docs build have passed, but I still think CI hasn't fully passed since MTK v9 merge, here's the test runs filtered on "success"
https://github.com/SciML/ModelingToolkitStandardLibrary.jl/actions/workflows/Downgrade.yml?query=is%3Asuccess
the last one appears to be before the v9 compat merge

@ChrisRackauckas
Copy link
Member

Downgrade can be ignored because that's a Pkg.jl issue. That's irrelevant to the CI failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants