Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translational.Free test is underconstrained #235

Closed
Keno opened this issue Oct 25, 2023 · 1 comment · Fixed by #236
Closed

Translational.Free test is underconstrained #235

Keno opened this issue Oct 25, 2023 · 1 comment · Fixed by #236

Comments

@Keno
Copy link

Keno commented Oct 25, 2023

This test:

ModelingToolkitStandardLibrary.jl/test/Mechanical/translational.jl

Line 32 in 0f0fae1

@test sol[s.free.f][end] ≈ 100 * 10

passes only by accident, because MTK happened to force acc.f to 0 (but it could have just as easily chosen free.f - SciML/ModelingToolkit.jl#2328 will give a warning in this case). The test is likely incorrect and should be fixed to do what is intended. It's also possible that free.f should be an observable rather than a variable.
@Keno
Copy link
Author

Keno commented Oct 25, 2023

cc @bradcarman

@bradcarman bradcarman mentioned this issue Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix test for Mechanical.Translational.Free component SciML/ModelingToolkitStandardLibrary.jl
1 participant
@Keno