Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DcMotor model #206

Closed
jevontech opened this issue Aug 10, 2023 · 2 comments
Closed

Add DcMotor model #206

jevontech opened this issue Aug 10, 2023 · 2 comments

Comments

@jevontech
Copy link

I am planning to add a DcMotor component composed of existing components to the library.
What would be the most appropriate location?
I was thinking of adding a new toplevel module ElectroMechanical (with submodules for Rotational and Translational?), but for example the EMF model is now located in Electrical.
Any suggestions ?

@jevontech jevontech closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2023
@ChrisRackauckas
Copy link
Member

Hey, is this going to be a more sophisticated DC motor model or is it going to be similar to one like the Modelica standard library?

@jevontech
Copy link
Author

I want to start with the basic DC motor model as used in the ModelingToolkitStandardLibrary example and then build other models later on. For now I will put them in my own library elan8/Elan8ComponentLibrary.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants