Fix the ConvectiveConductor equation and adds ConvectiveElement1D
#179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ortional to `dT` with thermal conductance `G`
Codecov Report
@@ Coverage Diff @@
## main #179 +/- ##
==========================================
- Coverage 66.18% 59.40% -6.78%
==========================================
Files 55 55
Lines 1999 2232 +233
==========================================
+ Hits 1323 1326 +3
- Misses 676 906 +230
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…ure drop and heat flow rate from `solid` to `fluid` + `ConvectiveConductor` and `ConvectiveResistor` extend the `Convective Element1D`
ven-k
changed the title
ConvectiveElement1D
YingboMa
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConvectiveElement1D, a partial model that defines temperature drop and heat flow rate fromsolidtofluid