Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mechanical/Translational libraries with both *position* and *velocity* based connectors #109

Closed
bradcarman opened this issue Sep 17, 2022 · 3 comments · Fixed by #114

Comments

@bradcarman
Copy link
Contributor

bradcarman commented Sep 17, 2022

Plan:

  • Put the velocity connector approach under "Mechanical/Translational" and position connector approach under "Mechanical/TranslationalPosition" (or maybe "Mechanical/Positional").
  • Add documentation to explain the theory and detail the differences. Will serve as a guide to aid in the decision of which approach to use for one's model.

Both libraries will be as similar as possible, with the only difference being the connector across variable. Because both libraries will export the same names, mixed use can/should only be done with namespaced use. Mixed use should likely be a rare case.

A start to the documentation can be found here: https://github.com/bradcarman/ModelingToolkitStandardLibrary.jl/blob/main/docs/connections.md

@ValentinKaisermayer
Copy link
Contributor

Can you add and demonstrate a component that measures the position for the velocity-based approach?

@ValentinKaisermayer
Copy link
Contributor

The rotational library follows the Modelica principles with absolute angle and torque and not the Simscape one with angular velocity and torque. Would you propose to make a separate library too in this case?

@bradcarman
Copy link
Contributor Author

Yes, I'll be explaining the position measurement in my documentation next. And I'll plan to open a separate PR for the Mechanical/Rotational components. For now I'll focus on the Translational part to see if everyone agrees with my idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants