Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish thermal models #1

Closed
ChrisRackauckas opened this issue Nov 2, 2021 · 5 comments
Closed

Finish thermal models #1

ChrisRackauckas opened this issue Nov 2, 2021 · 5 comments

Comments

@ChrisRackauckas
Copy link
Member

No description provided.

@ChrisRackauckas
Copy link
Member Author

Did #7 solve this @ValentinKaisermayer ?

@ValentinKaisermayer
Copy link
Contributor

Depends on what you think "finish" means?
As far as Modelica is concerned the only missing components are controlled sources. Other than that I think it is "finished".

Unless you also want fluid heat flow as well but that is a whole new issue.

@ChrisRackauckas
Copy link
Member Author

I just mean, are all of the blocks there, or a different suggested way to do it? I'll go make docs, and I think what we need for everything is either the block to exist, or some text that explains the "right way" to do it in MTK.

@ValentinKaisermayer
Copy link
Contributor

Most of the stuff from Thermal.HeatTransfer.Components is there. Only the two controlled sources are missing, related to #30. I think it is safe to close.

@ValentinKaisermayer ValentinKaisermayer mentioned this issue Jun 10, 2022
Merged
@ValentinKaisermayer
Copy link
Contributor

plot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrisRackauckas @ValentinKaisermayer