feat: add function to parse variable from string #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| $(TYPEDSIGNATURES) | ||
|
|
||
| Return the variable in `sys` referred to by its string representation `str`. |
src/systems/abstractsystem.jl
Outdated
| maybe_dummy_var = namespacedvar | namespacedvar "(t)" | | ||
| namespacedvar "(t)" "ˍ" ts | namespacedvar "ˍ" ts | | ||
| namespacedvar "ˍ" ts "(t)" | ||
| ts = "t" | "t" ts |
There was a problem hiding this comment.
nameof(independent_variable(sys))?
|
Codecov is at it again |
src/systems/abstractsystem.jl
Outdated
| # I'd write a regex to validate `str`, but https://xkcd.com/1171/ | ||
| str = strip(str) | ||
| derivative_level = 0 | ||
| while startswith(str, "D(") && endswith(str, ")") |
There was a problem hiding this comment.
We may need to validate that D is also the differential?
There was a problem hiding this comment.
D never shows up in expressions, it always prints as Differential(t)(x(t)). In the interest of concision, I assumed that D refers to the derivative with respect to the independent variable. I could also add a case that handles Differential(t)(x(t)) and validates that the independent variable matches?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.