Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add symbolic tstops support to ODESystem #3219

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@isaacsas
Copy link
Member

This is really nice. Is there any reason not to add to SDE and jump systems too?

@AayushSabharwal
Copy link
Member Author

I'm yet to add the solver infrastructure there

@ChrisRackauckas
Copy link
Member

What's up with the homotopy continuation tests? That's clearly not related though, but should get a follow up.

@ChrisRackauckas ChrisRackauckas merged commit 354c436 into SciML:master Nov 19, 2024
33 of 39 checks passed
@ChrisRackauckas
Copy link
Member

This is really nice. Is there any reason not to add to SDE and jump systems too?

The solvers will need to integrate with it. Let's allow this to be tried out a bit, but the interface in theory can work on any algorithm that defines the trait, so we can roll it out to more if it's working well. There's a few things to figure out with component handling with this.

@AayushSabharwal AayushSabharwal deleted the as/symbolic-tstops branch November 19, 2024 18:20
@AayushSabharwal
Copy link
Member Author

What's up with the homotopy continuation tests? That's clearly not related though, but should get a follow up.

Weird that the only failure is on LTS. I'll investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants