Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't bold model name etc in show #2576

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

oxinabox
Copy link
Contributor

@oxinabox oxinabox commented Mar 26, 2024

The idea i propose is that nothing that is derived from the model should be printed bold.
That then makes it stand out more because of contrast.
This is however very bike-shed-able

before
Screenshot from 2024-03-26 23-58-32

after
image

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

I didn't even realize that the model name was printed til today when I was like "why isn't the model name printed?"

@oxinabox
Copy link
Contributor Author

oxinabox commented May 2, 2024

bump

@ChrisRackauckas
Copy link
Member

Do we want this? It's not clear to me.

@oxinabox
Copy link
Contributor Author

oxinabox commented May 2, 2024

my argument is that we should consistently format anything coming from the model (currently nonbold in this PR)
vs the "template" text we use to describe it (currently bold) in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants