From a9f210691c1f38ef0f575eb89a939763b81c9c1b Mon Sep 17 00:00:00 2001
From: vyudu <vincent.duyuan@gmail.com>
Date: Tue, 3 Dec 2024 19:11:35 -0500
Subject: [PATCH] up

---
 src/systems/diffeqs/abstractodesystem.jl | 4 ++--
 test/bvproblem.jl                        | 8 ++++----
 test/runtests.jl                         | 1 +
 3 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/systems/diffeqs/abstractodesystem.jl b/src/systems/diffeqs/abstractodesystem.jl
index b795bb981d..8dac19f296 100644
--- a/src/systems/diffeqs/abstractodesystem.jl
+++ b/src/systems/diffeqs/abstractodesystem.jl
@@ -534,7 +534,7 @@ function SciMLBase.BVProblem{iip, specialize}(sys::AbstractODESystem, u0map = []
 
     # Define the boundary conditions.
     bc = if iip 
-        (residual, u, p, t) -> (residual .= u[1] - _u0)
+        (residual, u, p, t) -> (residual .= u[1] .- _u0)
     else
         (u, p, t) -> (u[1] - _u0)
     end
@@ -542,7 +542,7 @@ function SciMLBase.BVProblem{iip, specialize}(sys::AbstractODESystem, u0map = []
     return BVProblem{iip}(f, bc, u0, tspan, p; kwargs1..., kwargs...)
 end
 
-get_callback(prob::BVProblem) = prob.kwargs[:callback]
+get_callback(prob::BVProblem) = error("BVP solvers do not support callbacks.")
 
 """
 ```julia
diff --git a/test/bvproblem.jl b/test/bvproblem.jl
index 4865c867b3..7235638cf0 100644
--- a/test/bvproblem.jl
+++ b/test/bvproblem.jl
@@ -23,8 +23,8 @@ sol2 = solve(bvp, MIRK4(), dt = 0.01);
 op = ODEProblem(lotkavolterra, u0map, tspan, parammap)
 osol = solve(op, Vern9())
 
-@test isapprox(sol.u[end],osol.u[end]; atol = 0.001)
-@test isapprox(sol2.u[end],osol.u[end]; atol = 0.001)
+@test isapprox(sol.u[end],osol.u[end]; atol = 0.01)
+@test isapprox(sol2.u[end],osol.u[end]; atol = 0.01)
 @test sol.u[1] == [1., 2.]
 @test sol2.u[1] == [1., 2.]
 
@@ -50,7 +50,7 @@ sol2 = solve(bvp2, MIRK4(), dt = 0.01);
 op = ODEProblem(pend, u0map, tspan, parammap)
 osol = solve(op, Vern9())
 
-@test sol.u[end] ≈ osol.u[end]
+@test isapprox(sol.u[end], osol.u[end]; atol = 0.01)
 @test sol.u[1] == [π/2, π/2]
-@test sol2.u[end] ≈ osol.u[end]
+@test isapprox(sol2.u[end], osol.u[end]; atol = 0.01)
 @test sol2.u[1] == [π/2, π/2]
diff --git a/test/runtests.jl b/test/runtests.jl
index 44846eed57..eaa87e6407 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -80,6 +80,7 @@ end
             @safetestset "NonlinearSystem Test" include("nonlinearsystem.jl")
             @safetestset "PDE Construction Test" include("pde.jl")
             @safetestset "JumpSystem Test" include("jumpsystem.jl")
+            @safetestset "BVProblem Test" include("bvproblem.jl")
             @safetestset "print_tree" include("print_tree.jl")
             @safetestset "Constraints Test" include("constraints.jl")
         end