Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out MonteCarloIntegration.jl into extension package #207

Open
frankier opened this issue Dec 13, 2023 · 2 comments
Open

Factor out MonteCarloIntegration.jl into extension package #207

frankier opened this issue Dec 13, 2023 · 2 comments

Comments

@frankier
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently https://github.com/ranjanan/MonteCarloIntegration.jl depends on an old version of https://github.com/SciML/QuasiMonteCarlo.jl/ . It would be nice if it was possible to use this package and new versions of QuasiMonteCarlo.jl

Describe the solution you’d like

Factoring MonteCarloIntegration.jl into an extension package would help. Especially since MCIntegration.jl will be added soon, which could be a reasonable alternative.

Describe alternatives you’ve considered

Updating MonteCarloIntegration.jl . However, this has been delayed for quite a while. There have also been other problems like #195

I guess it is still maintained but slowly so the extension package approach might make sense for the time being at least. If it ends up being useful in addition to MCIntegration.jl long-term, it may need new maintainer. Otherwise I guess MCIntegration.jl will superceed it.

Who will do it

I can make a PR for this change after preliminary approval if but only in case it would be helpful.

@ChrisRackauckas
Copy link
Member

Yes. It is basically superseded by MCIntegration.jl at this point, so #202 is going to move it to an extension and make MCIntegration.jl the new core dep.

@frankier
Copy link
Contributor Author

That makes sense, however just FYI in my opinion it is not yet at feature parity since it doesn't seem to support QMC numericalEFT/MCIntegration.jl#53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants