Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mario animation helper bone errors #177

Open
Metro-Shroomin opened this issue Jan 22, 2024 · 1 comment
Open

Mario animation helper bone errors #177

Metro-Shroomin opened this issue Jan 22, 2024 · 1 comment
Labels
bug Something isn't working ssbh_wgpu rendering library

Comments

@Metro-Shroomin
Copy link

Some animations have issues with vertices being scrunched around the waist bone
example0

@ScanMountGoat ScanMountGoat added bug Something isn't working ssbh_wgpu rendering library labels Jan 22, 2024
@ScanMountGoat
Copy link
Owner

ScanMountGoat commented Jan 22, 2024

If I recall, this has something to do with the rotation sign flipping when evaluating helper bone constraints. I also don't apply all the rotation values. This will require additional test cases in the ssbh_wgpu repository if someone wants to look into this. It shouldn't have any impact on how the animation renders in game when saving from SSBH Editor.

Relevant rendering code:
https://github.com/ScanMountGoat/ssbh_wgpu/blob/a1ab04d4e2ba15e4da1af56b70fb8479ff4a2016/ssbh_wgpu/src/animation/constraints.rs#L59

@ScanMountGoat ScanMountGoat changed the title Animation Rendering Errors Mario animation helper bone errors Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ssbh_wgpu rendering library
Projects
None yet
Development

No branches or pull requests

2 participants