Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIF saving progress bar #112

Open
zrksyd opened this issue Oct 4, 2022 · 3 comments
Open

GIF saving progress bar #112

zrksyd opened this issue Oct 4, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@zrksyd
Copy link
Contributor

zrksyd commented Oct 4, 2022

I attempted to implement this myself, but no change shows up so I'm not sure what's going on.
zrksyd@be1a16a

@ScanMountGoat
Copy link
Owner

ScanMountGoat commented Oct 4, 2022

That code would probably work in some other UI frameworks you might be used to in languages like C#. The current implementation is blocking the main thread while processing the GIF, which is why I plan to use a separate thread before I release it. The main update loop in ssbh_editor is a little disorganized, so I would look at the egui docs to get a feel for how the application loop works. The UI is drawn each update loop rather than in response to some user input or change in value. If the main thread is stuck doing some computation, the app.update function won't be called yet.

https://docs.rs/egui/latest/egui/#integrating-with-egui

@zrksyd
Copy link
Contributor Author

zrksyd commented Oct 4, 2022

Will you consider adding this yourself? It might be better to combine this with your separate thread implementation.

@ScanMountGoat
Copy link
Owner

The threading is something I need to add myself because it interacts with the rendering backend. I plan on adding a progress indicator, but I'm not sure if it will make it into the next release or not.

@ScanMountGoat ScanMountGoat added the enhancement New feature or request label Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants