-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add effect lighting to shader database #32
Comments
This would require checking the decompiled shaders to see if there is a specific attribute or uniform parameter used for effect lighting. The shader labels themselves are just strings. I don't have any rendering for effect lighting, so this isn't a big priority for me at the moment. I've outlined the steps below if anyone wants to make an attempt at figuring it out.
|
This should be a lot easier with the dump of annotated decompiled shaders. You should be able to just diff the vertex or fragment shaders for the two shader labels in the annotated dump and check for missing parameters. Check the nufxlb JSON for which vertex and fragment shaders match up with each shader label. |
It looks like You should be able to put together a script that maps shader labels to vertex shaders using the nufx JSON and checks the annotated dump for effect lighting params. I don't plan to add effect lighting to the info JSON yet since it hasn't been researched very much and isn't part of ssbh_wgpu's rendering. |
Some shaders have a unique attribute to disable receival of effect lighting. The following two shader labels are emission only, but only the latter shader label disables receival of effect lighting:
The following picture demonstrates when this attribute is enabled and when it is disabled. The stage's uppermost pink surface is a separate mesh from the rest of the stage, and as a result is what is affected by the changes.
The text was updated successfully, but these errors were encountered: