New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues in Logdump module #6400

Open

kishore-sn opened this issue Sep 16, 2024 · 0 comments

Contributor

kishore-sn commented Sep 16, 2024

          There are 3 strncmp s to check a command. It looks not good.

Because the data is a just character, how about using switch / case?

Here you added the else case to check stop first. How about adding it at the read function as well? Because it's the same.

Originally posted by @sunghan-chang in #6394 (comment)

Line number 292 and 524

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment