Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix localization specific digit separators breaking compilation #37

Open
Sceptr opened this issue Jul 16, 2016 · 0 comments
Open

Fix localization specific digit separators breaking compilation #37

Sceptr opened this issue Jul 16, 2016 · 0 comments

Comments

@Sceptr
Copy link

Sceptr commented Jul 16, 2016

I cannot type in 0.8, as the "." gets deleted after saving. And 0,8 corrupts the file because the program thinks everything AFTER the comma belongs to the next specifier.

For example Bayonetta´s Dash Attack (game):

-Unedited, usual:
Asynchronous_Timer(Frames=1) unk_1B41048C(unknown=0x1, unknown=0x1, unknown=0x1, unknown=0x0, unknown=0xA, unknown=0x3, unknown=0xF, unknown=0x5, unknown=0x1) Set_Frame_Duration(Speed=0,8) Asynchronous_Timer(Frames=18) Set_Frame_Duration(Speed=1,4) Extended_Special_Hitbox(ID=0x0, Part=0x0, Bone=0x0, Damage=10, Angle=0x32, KBG=0x37, FKB=0x0, BKB=0x55, Size=4,2, Z=0, Y=10, X=10, Effect=0x0, Trip=0, Hitlag=1, SDI=1, Clang=0x1, Rebound=0x1, ShieldDamage=0x1, SFXLevel=0x2, SFXType=0x2, Ground/Air=0x3, Direct/Indirect=0x1, Type=0x4, Action=0x3F, Unknown=0x0, Unknown=0xF, Unknown=0x0, Blockability=0x1, Reflectable=0x0, Absorbable=0x0, Rehit=0x0, IgnoreInvuln=0x0, Unknown=0x0, FacingRestrict=0x3, Unknown=0x0, TeamDamage=0x0, DisableHitlag=0x0, NoGFX=0x0, flinchless=0x0, WarpZ=0, WarpY=10, WarpX=6) Synchronous_Timer(Frames=4) Extended_Special_Hitbox(ID=0x0, Part=0x0, Bone=0x0, Damage=8, Angle=0x32, KBG=0x37, FKB=0x0, BKB=0x55, Size=4,2, Z=0, Y=10, X=10, Effect=0x0, Trip=0, Hitlag=1, SDI=1, Clang=0x1, Rebound=0x1, ShieldDamage=0x1, SFXLevel=0x1, SFXType=0x2, Ground/Air=0x3, Direct/Indirect=0x1, Type=0x4, Action=0x3F, Unknown=0x0, Unknown=0xF, Unknown=0x0, Blockability=0x1, Reflectable=0x0, Absorbable=0x0, Rehit=0x0, IgnoreInvuln=0x0, Unknown=0x0, FacingRestrict=0x3, Unknown=0x0, TeamDamage=0x0, DisableHitlag=0x0, NoGFX=0x0, flinchless=0x0, WarpZ=0, WarpY=10, WarpX=6) Synchronous_Timer(Frames=4) Remove_All_Hitboxes() Asynchronous_Timer(Frames=27) unk_B2E91D0C(unknown=0x3F800000) Asynchronous_Timer(Frames=28) Set_bit(Unknown=0x20000085) Set_bit(Unknown=0x20000086) Set_bit(Unknown=0x20000087) Script_End()

Unedited, after saving:
Asynchronous_Timer(Frames=1) unk_1B41048C(unknown=0x1, unknown=0x1, unknown=0x1, unknown=0x0, unknown=0xA, unknown=0x3, unknown=0xF, unknown=0x5, unknown=0x1) Set_Frame_Duration(Speed=0) Asynchronous_Timer(Frames=18) Set_Frame_Duration(Speed=1)

I tried it in every release. only in nightly it deletes hitboxes the others shift every number of the worked on part of the file.
Here an example:
From:
...
Set_Frame_Duration(Speed=0,8)
Asynchronous_Timer(Frames=18)
Set_Frame_Duration(Speed=1,4)
...
To:
...
Set_Frame_Duration(Speed=0)
Asynchronous_Timer(Frames=8)
Set_Frame_Duration(Speed=18)
...(...=1)...(...=4)

jam1garner.py at the SM4SH Modding Discord comunity suggested i should report this here.
He wrote:

Just post a bug report on his github or something

Could you, please, fix this, @Sammi-Husky ? I´d love to be able to use your tool as you meant it to be used. Thanks in advance.

@Sammi-Husky Sammi-Husky changed the title Only Whole Numbers! 0.8 or 0,8? Neither work. (Bug?) Fix localization specific digit separators breaking compilation Sep 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants