Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error setting contextual locations could cause infinite loop #55

Open
mattatcha opened this issue May 9, 2014 · 1 comment
Open

Error setting contextual locations could cause infinite loop #55

mattatcha opened this issue May 9, 2014 · 1 comment

Comments

@mattatcha
Copy link
Contributor

If you don't set contextual on a contextual route it could cause the browser to redirect indefinitely. I accidently did this in Chrome and the only way to stop it was to kill the tabs process.

MainPage

<Locations hash>
  <Location path="/" handler={MainPage} />
  <Location path="/users/*" handler={UserPage} />
</Locations>

UserPage

<Locations>
  <Location path="/" handler={UserListPage} />
  <Location path="/:username" handler={UserPage} />
</Locations>
@fgnass
Copy link
Contributor

fgnass commented Jul 7, 2014

Not sure if this is in fact related, but while reading the RouterMixin sources I came across this while loop and wondered if this could result in infinite loops under certain circumstances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants