Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some newer device headers are inconsistently including <core_cm...h> instead of "core_cm...h" #32

Open
gfuehrer opened this issue Apr 18, 2024 · 4 comments
Assignees
Labels
cmsis CMSIS-related issue or pull-request. internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system

Comments

@gfuehrer
Copy link

Historically, device headers, eg stm32F303.h, have lines like this:

#include "core_cm4.h"            /* Cortex-M4 processor and core peripherals */
#include "system_stm32f3xx.h"    /* STM32F3xx System Header */

But in some newer ones, eg stm32L562.h, it is now like this:

#include <core_cm33.h>                      /*!< ARM Cortex-M33 processor and core peripherals */
#include "system_stm32l5xx.h"               /*!< STM32L5xx System */

Putting just the one CMSIS header but not the other in the -isystem search path instead of the -iquote search path is, obviously, crazed. I think they correctly belong in the -iquote search path, and why change from the past?

Please replace #include <core_cm...h> with #include "core_cm...h" everywhere that it got messed up.

@RJMSTM RJMSTM self-assigned this May 21, 2024
@RJMSTM
Copy link

RJMSTM commented May 21, 2024

Hello @gfuehrer,

In fact, there is no mistake in your statement. The STM32F3 series contains the Cortex-M4 core, while the STM32L5 series includes the Cortex-M33 core.

image
therefore
image

As long as there is no issue with our firmware, please allow me to close this issue.

Regards,
Rania

@RJMSTM RJMSTM added the invalid This doesn't seem right label May 21, 2024
@RJMSTM RJMSTM added the cmsis CMSIS-related issue or pull-request. label May 22, 2024
@RJMSTM RJMSTM closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2024
@salkinium
Copy link

@RJMSTM Please re-open this issue and re-read the issue description. The problem is the difference between <> and "", NOT the Cortex-M type.

@RJMSTM RJMSTM reopened this May 22, 2024
@RJMSTM
Copy link

RJMSTM commented May 22, 2024

Hello @salkinium ,

I apologize for the confusion regarding your issue, I will forward your question on to our development team.

Regards,

@RJMSTM RJMSTM removed the invalid This doesn't seem right label Jun 6, 2024
@RJMSTM
Copy link

RJMSTM commented Jul 15, 2024

ST Internal Reference: 186603

@RJMSTM RJMSTM added the internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmsis CMSIS-related issue or pull-request. internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system
Projects
Development

No branches or pull requests

3 participants