Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es-wifi: why not creating a submodule ? #93

Open
joelguittet opened this issue Aug 5, 2024 · 3 comments
Open

es-wifi: why not creating a submodule ? #93

joelguittet opened this issue Aug 5, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system mw Middleware-related issue or pull-request. wifi WiFi-related issue or pull-request

Comments

@joelguittet
Copy link

Hello,

The es-wifi driver is used twice here for the B-L475E-IOT01A and B-L4S5I-IOT01A and additionally in the X-CUBE-GNSS package at https://github.com/STMicroelectronics/x-cube-gnss1.

While it's not really a big library and so not a big issue, the most important is that they are all different!!! I created a PR on this repository to fix an UDP issue (see #92) but the X-CUBE-GNSS package as a similar one too.

Why not creating submodules when you have this kind of libraries ? Here for the es-wifi driver this is a perfect example where maintenance of this stuff will be greatly simplified.

Joel

@ALABSTM ALABSTM self-assigned this Aug 7, 2024
@ALABSTM ALABSTM added enhancement New feature or request mw Middleware-related issue or pull-request. wifi WiFi-related issue or pull-request labels Aug 7, 2024
@ALABSTM ALABSTM added spotted before customer Spotted and fixed internally before being pointed out by users but not published yet and removed spotted before customer Spotted and fixed internally before being pointed out by users but not published yet labels Aug 7, 2024
@ALABSTM
Copy link
Contributor

ALABSTM commented Aug 7, 2024

Hi @joelguittet,

Thank you for this proposal. Actually, replacing BSP drivers by submodules is already in the pipe. However, the es-wifi looks to be a particular case as it is not located under ./Drivers/BSP/Components.

I have first to check with our development teams. I will get back to you once I have their feedback.

With regards,

@joelguittet
Copy link
Author

Hello @ALABSTM
Awesome 👍 thanks for this feedback.
Joel

@ALABSTM ALABSTM added the internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system label Sep 12, 2024
@ALABSTM
Copy link
Contributor

ALABSTM commented Sep 12, 2024

ST Internal Reference: 190925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system mw Middleware-related issue or pull-request. wifi WiFi-related issue or pull-request
Projects
Status: In progress
Development

No branches or pull requests

2 participants